Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨[feature Request]: Changing Navbar #186

Closed
4 tasks done
Anjaliavv51 opened this issue Oct 4, 2024 · 7 comments · Fixed by #222
Closed
4 tasks done

✨[feature Request]: Changing Navbar #186

Anjaliavv51 opened this issue Oct 4, 2024 · 7 comments · Fixed by #222
Assignees
@Mayukh-Mandal2005
Labels
enhancement New feature or request gssoc-ext hacktoberfest-accepted Level 3

Comments

@Anjaliavv51
Copy link
Owner

Anjaliavv51 commented Oct 4, 2024 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Feature Description

Need to improve navbar UI

Benefits

First Come First serve who will ping first will be assigned first and awrded level 3 , they need make UI navbar Great and also , navbar should be implemented to all html pages in repo.

Add ScreenShots

Before :

image

After :

Their should be a floating navbar , with curved edges and on hover over the link's , underlining should be displayed with glowing effect.

Priority

High

Record

  • I have read the Contributing Guidelines
  • I'm a GSSOC'24EXTD contributor
  • I have starred the repository
@Anjaliavv51 Anjaliavv51 pinned this issue Oct 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024

Hi there! Thanks for opening this issue @Anjaliavv51!. We appreciate your contribution to this open-source project. We aim to respond or assign your issue as soon as possible.

@Mayukh-Mandal2005
Copy link
Contributor

Mayukh-Mandal2005 commented Oct 4, 2024 •
edited
Loading

Hey @Anjaliavv51
How do you want you navbar?
As the pic you uploaded is not visible
Kindly update me with the details as I am ready to work on this issue

@Mayukh-Mandal2005
Copy link
Contributor

Please assign me this issue @Anjaliavv51

@Anjaliavv51
Copy link
Owner Author

@Mayukh-Mandal2005
https://meet.google.com/xqp-vcii-ktj
please join the meet

@Anjaliavv51 Anjaliavv51 unpinned this issue Oct 4, 2024
@Anjaliavv51 Anjaliavv51 pinned this issue Oct 4, 2024
@Mayukh-Mandal2005
Copy link
Contributor

Hey @Anjaliavv51
I was working on the navbar ui and then saw that the navbar could not be margined from the right side of the edge of page
image
I don't know what is the issue
So should I leave it like this?

@Anjaliavv51
Copy link
Owner Author

Hey @Anjaliavv51 I was working on the navbar ui and then saw that the navbar could not be margined from the right side of the edge of page image I don't know what is the issue So should I leave it like this?

It looks great, Please implement it to all html pages

@Mayukh-Mandal2005
Copy link
Contributor

Okay sure Ma'am

Anjaliavv51 added a commit that referenced this issue Oct 5, 2024
@Anjaliavv51
✨[feature Request]: Changing Navbar #186 (#222)
f833854 

<!-- ISSUE & PR TITLE SHOULD BE SAME-->
## Description
Updated the Navbar UI as asked in the issue column 
Added rounded corners with white background, underline and glowing
effect on the tabs in navbar of each page with adding 1-2 more features
such as cart image with count option on each page


## Related Issues

<!--Cite any related issue(s) this pull request addresses. If none,
simply state “None”-->
- Closes #

## Type of PR
<!-- Mention PR Type according to the issue in brackets below and check
the below box -->
- [✔️ ] (Feature update, Code Refactor)

## Screenshots / videos (if applicable)
<!--Attach any relevant screenshots or videos demonstrating the
changes-->
Image of website before the Navbar UI -

![image](https://github.com/user-attachments/assets/0d283d2d-601c-4ba2-8cf6-3c499c02ebba)

Images of website after the updated Navbar UI-

![image](https://github.com/user-attachments/assets/7f68e855-a083-4976-82e2-e0e6906f4bec)

![image](https://github.com/user-attachments/assets/824dabcf-b41b-4ca1-b281-67553eb8d07d)


## Checklist
<!-- [X] - put a cross/X inside [] to check the box -->
- [✔️ ] I have gone through the [contributing
guide](https://github.com/Anjaliavv51/Retro)
- [✔️ ] I have updated my branch and synced it with project `main`
branch before making this PR
- [ ✔️] I have performed a self-review of my code
- [ ✔️] I have tested the changes thoroughly before submitting this pull
request.
- [ ✔️] I have provided relevant issue numbers, screenshots, and videos
after making the changes.
- [ ✔️] I have commented my code, particularly in hard-to-understand
areas.


## Additional context:
<!--Include any additional information or context that might be helpful
for reviewers.-->
@Mayukh-Mandal2005 Mayukh-Mandal2005 mentioned this issue Oct 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mayukh-Mandal2005 Mayukh-Mandal2005

Labels
enhancement New feature or request gssoc-ext hacktoberfest-accepted Level 3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

✨[feature Request]: Changing Navbar #186 Mayukh-Mandal2005/Retro
2 participants
@Mayukh-Mandal2005 @Anjaliavv51