Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible changes to instant sharing custom messages feature #636

Open
UVLabs opened this issue Jul 30, 2020 · 0 comments
Open

Possible changes to instant sharing custom messages feature #636

UVLabs opened this issue Jul 30, 2020 · 0 comments

Comments

@UVLabs
Copy link
Contributor

UVLabs commented Jul 30, 2020

  • Allow saving of custom instant messages for posts that are in Pending, so that when being reviewed, the post would already have custom messages.

Usecase:

Writer entering custom share messages
Admin altering those custom messages or choosing to publish as is

  • Allow saving of custom instant messages for scheduled posts. Right now this feature solely depends on if the option is checked in the general settings of ROP. But if a post is a draft, and a user saves it as "scheduled" with custom instant share messages, then when that post changes from "scheduled" to "published" and the share is triggered. It should pull the custom share message one it exists.

Change this:

https://github.com/Codeinwp/tweet-old-post/blob/v8511/includes/admin/class-rop-admin.php#L707

Add check for custom messages here:

https://github.com/Codeinwp/tweet-old-post/blob/v8511/includes/admin/class-rop-admin.php#L786

Or here (might be better here):

https://github.com/Codeinwp/tweet-old-post/blob/v8511/includes/admin/models/class-rop-queue-model.php#L325

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant