Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shows the next days date #450

Open
Khayoon opened this issue Feb 8, 2023 · 1 comment
Open

Shows the next days date #450

Khayoon opened this issue Feb 8, 2023 · 1 comment
Labels
question Further information is requested

Comments

@Khayoon
Copy link

Khayoon commented Feb 8, 2023

Describe the bug
The date displayed in the profile section of the Streak Stats Heroku app is incorrect, showing 8th instead of 7th.

To Reproduce

  1. Access a profile with a section on the streak stats.
  2. Observe the incorrect date display.

Expected behavior
The date field should display the correct date, i.e. 7th, and count the streak correctly.

Screenshot: Attached for reference.
Screenshots

  • OS: windows 10
  • Browser chrome
  • Version 106.0.5249.119
@Khayoon Khayoon added the bug Something isn't working label Feb 8, 2023
@DenverCoder1
Copy link
Owner

DenverCoder1 commented Feb 14, 2023

The stats are all generated on the server where the timezone is constant for all requests (I believe it is UTC). It is possible for it to be Feb 8 in one timezone while it is Feb 7 in your own.

A possible solution for this would be to have a parameter for setting the timezone for dealing with today's date. I feel slightly against doing this since it could be confused with setting the timezone for how contributions are fetched which is not currently possible with the GitHub API as far as I am aware.

@DenverCoder1 DenverCoder1 added question Further information is requested and removed bug Something isn't working labels Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants