Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly change returned rejected promise to thrown error? #83

Open
glebec opened this issue Sep 19, 2016 · 0 comments
Open

Possibly change returned rejected promise to thrown error? #83

glebec opened this issue Sep 19, 2016 · 0 comments

Comments

@glebec
Copy link
Member

glebec commented Sep 19, 2016

https://github.com/FullstackAcademy/fsg/blob/master/generated/browser/js/fsa/fsa-pre-built.js#L93 returns a rejected promise with an object that has a message. Is there any compelling reason to do this over throw Error('message string')?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant