Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ChromeContentBrowserClient::GetUserAgentBasedOnPolicy to avoid duplication #4

Open
jdapena opened this issue Mar 8, 2023 · 0 comments
Open

Refactor ChromeContentBrowserClient::GetUserAgentBasedOnPolicy to avoid duplication #4

jdapena opened this issue Mar 8, 2023 · 0 comments
Labels
enhancement New feature or request upstream_delta Work to reduce delta with upstream Chromium

Comments

@jdapena
Copy link
Member

jdapena commented Mar 8, 2023

As told in #2 (comment) it would be good to refactor the method ChromeContentBrowserClient::GetUserAgentBasedOnPolicy() from upstream, moving most of its implementation to //components/embedded_support so it can be reused by other embedders as Wolvic Chromium backend.

Then, once we are based on a version of Chromium using that change, update accordingly to use the refactored version.
@jdapena jdapena added enhancement New feature or request upstream_delta Work to reduce delta with upstream Chromium labels Mar 8, 2023
zakharvoit pushed a commit that referenced this issue May 12, 2023
Update LUCI config for M112
56b9e42 
[email protected]

Change-Id: Ib5d5eda3c8b2672525558ff03b437fe1567f892b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4289430
Reviewed-by: Sven Zheng <[email protected]>
Commit-Queue: Srinivas Sista <[email protected]>
Owners-Override: Srinivas Sista <[email protected]>
Cr-Commit-Position: refs/branch-heads/5615@{#4}
Cr-Branched-From: 9c6408e-refs/heads/main@{#1109224}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request upstream_delta Work to reduce delta with upstream Chromium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jdapena