Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📝 Documentation: valid-name and valid-version rules claim hasSuggestions: true, but don't have suggestions #255

Closed
2 tasks done
JoshuaKGoldberg opened this issue Mar 27, 2024 · 1 comment · Fixed by #299
Closed
2 tasks done

📝 Documentation: valid-name and valid-version rules claim hasSuggestions: true, but don't have suggestions #255

JoshuaKGoldberg opened this issue Mar 27, 2024 · 1 comment · Fixed by #299
Labels
area: documentation Improvements or additions to docs good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Mar 27, 2024 •
edited
Loading

Bug Report Checklist

Overview

Neither of these rules include a suggest property in their reports. So the following two lines should be deleted:

eslint-plugin-package-json/src/rules/valid-name.ts

Line 51 in 2ce1881

hasSuggestions: true,

eslint-plugin-package-json/src/rules/valid-version.ts

Line 42 in 2ce1881

hasSuggestions: true,

Additional Info

This would likely be detected by #82. Filing this issue as a nice good first issue to tackle beforehand.
@JoshuaKGoldberg JoshuaKGoldberg added area: documentation Improvements or additions to docs type: bug Something isn't working :( good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this! labels Mar 27, 2024
@hyoban hyoban mentioned this issue Apr 11, 2024
Merged
3 tasks
JoshuaKGoldberg pushed a commit that referenced this issue Apr 11, 2024
@hyoban
fix: correct suggestion status (#299)
146e25d 
<!-- 👋 Hi, thanks for sending a PR to eslint-plugin-package-json! 💖.
Please fill out all fields below and make sure each item is true and [x]
checked.
Otherwise we may not be able to review your PR. -->

## PR Checklist

-   [x] Addresses an existing open issue: fixes #255
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

<!-- Description of what is changed and how the code change does that.
-->
@github-actions GitHub Actions
Copy link

🎉 This is included in version v0.13.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: documentation Improvements or additions to docs good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: correct suggestion status hyoban/eslint-plugin-package-json
1 participant
@JoshuaKGoldberg