Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it easier to integration test config options #261

Open
benjaminjkraft opened this issue Mar 1, 2023 · 0 comments
Open

Make it easier to integration test config options #261

benjaminjkraft opened this issue Mar 1, 2023 · 0 comments
Labels
help wanted Issues that anyone could pick up and implement if useful to them internal needs design Issues where we don't know exactly what we need yet; discuss on the issue before implementing

Comments

@benjaminjkraft
Copy link
Collaborator

benjaminjkraft commented Mar 1, 2023 •
edited
Loading

Our integration tests all run with a single config, which makes it hard to integration test a change like #252. Ideally we should do some reworking so we can test them against several configs, like we do in the snapshot tests. We'll have to think about what the best way is.

Once we do, we should add integration tests for #252, which should be fairly easy once the tooling is there.
@benjaminjkraft benjaminjkraft added help wanted Issues that anyone could pick up and implement if useful to them internal needs design Issues where we don't know exactly what we need yet; discuss on the issue before implementing labels Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Issues that anyone could pick up and implement if useful to them internal needs design Issues where we don't know exactly what we need yet; discuss on the issue before implementing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@benjaminjkraft