Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't we write a recommended version of PHP? #85

Open
fumiya5863 opened this issue Jan 3, 2021 · 2 comments
Open

Shouldn't we write a recommended version of PHP? #85

fumiya5863 opened this issue Jan 3, 2021 · 2 comments

Comments

@fumiya5863
Copy link

fumiya5863 commented Jan 3, 2021

The PHP formula says random_bytes is greater than or equal to 7.0

Note: Although this function was added to PHP in PHP 7.0

Wouldn't it be better to write that 7.0 or higher is recommended for README?

@MarkMaldaba
Copy link

The code is written with a number of fallbacks. It uses random_bytes() if it is available, but has a number of other alternatives if not. Therefore, the module currently works on a large number of PHP versions, at least as far back as PHP 5.3, if not further (whilst also working on the latest PHP releases).

It might still be worth explicitly stating the versions of PHP that are supported, though.

@fumiya5863
Copy link
Author

Thank you for your comment. Certainly, I think it would be good for future users to list the PHP version in the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants