-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: release advanced patch option types #26
Comments
The option types should be structured in it's own Gradle subproject. The subproject is to be then released as a maven package. Patches then have to shade the classes, otherwise they will not work outside of ReVanced Manager because the types would be missing |
This can be moved to the ReVanced Library repository @oSumAtrIX |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Which abstract types are needed? |
Those are the ones I can state of the top of my head, @PalmDevs may have more to add |
Former 3 will abstract String but former 2 can abstract File. For the last one, decimal and integral numbers are supported as primitive types already. |
Also include resource name which will abstract String. Eg. |
Feature description
Introduce Patch Option Types such as Color, which extend on ReVanced Patcher types
Motivation
The ability to use the best-fitting UI for patch options in GUI frontends, while keeping only the necessary types in ReVanced Patcher which has refused to implement these types
Additional context
Perhaps this can be moved to ReVanced Library
Acknowledgements
The text was updated successfully, but these errors were encountered: