Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: FailedToFindInstalledPackageException when installing with --mount #64

Closed
3 tasks done
ricnava00 opened this issue Nov 11, 2024 · 2 comments · May be fixed by #65
Closed
3 tasks done

bug: FailedToFindInstalledPackageException when installing with --mount #64

ricnava00 opened this issue Nov 11, 2024 · 2 comments · May be fixed by #65
Labels
Bug report Something isn't working

Comments

@ricnava00
Copy link
Contributor

Bug description

java -jar revanced-cli-5.0.0-all.jar patch -p patches-5.0.1.rvp -i [serial] -o output.apk --mount com.google.android.youtube_19.43.41.apk

Raises FailedToFindInstalledPackageException

Error logs

...
INFO: Installing com.google.android.youtube by mounting
app.revanced.library.installation.installer.RootInstaller$FailedToFindInstalledPackageException: Failed to find installed package "com.google.android.youtube" because no activity was found
        at app.revanced.library.installation.installer.RootInstaller.assertInstalled(RootInstaller.kt:126)
        at app.revanced.library.installation.installer.RootInstaller.install$suspendImpl(RootInstaller.kt:55)
        at app.revanced.library.installation.installer.RootInstaller.install(RootInstaller.kt)
        at app.revanced.cli.command.PatchCommand$run$4$1.invokeSuspend(PatchCommand.kt:360)
        at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
        at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:104)
        at kotlinx.coroutines.EventLoopImplBase.processNextEvent(EventLoop.common.kt:277)
        at kotlinx.coroutines.BlockingCoroutine.joinBlocking(Builders.kt:95)
        at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking(Builders.kt:69)
        at kotlinx.coroutines.BuildersKt.runBlocking(Unknown Source)
        at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking$default(Builders.kt:48)
        at kotlinx.coroutines.BuildersKt.runBlocking$default(Unknown Source)
        at app.revanced.cli.command.PatchCommand.run(PatchCommand.kt:359)
        at picocli.CommandLine.executeUserObject(CommandLine.java:2030)
        at picocli.CommandLine.access$1500(CommandLine.java:148)
        at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2465)
        at picocli.CommandLine$RunLast.handle(CommandLine.java:2457)
        at picocli.CommandLine$RunLast.handle(CommandLine.java:2419)
        at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2277)
        at picocli.CommandLine$RunLast.execute(CommandLine.java:2421)
        at picocli.CommandLine.execute(CommandLine.java:2174)
        at app.revanced.cli.command.MainCommandKt.main(MainCommand.kt:12)

Solution

Unfortunately I couldn't verify this, but it seems to me that the condition in

revanced-library/src/commonMain/kotlin/app/revanced/library/installation/installer/RootInstaller.kt

Line 125 in cace517

if (INSTALLED_APK_PATH(this)().output.isNotEmpty()) {
is inverted

Additional context

Running:
pm path com.google.android.youtube
Returns:
package:/data/app/~~_bb1lYTjLPKioHG4NpBMhQ==/com.google.android.youtube-CYzdlf-q6aJnotZmD7abCA==/base.apk

Acknowledgements

  • I have checked all open and closed bug reports and this is not a duplicate.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
@ricnava00 ricnava00 added the Bug report Something isn't working label Nov 11, 2024
@oSumAtrIX
Copy link
Member

May be fixed with 649f06b. You can test by bumping the version of the library in ReVanced CLI.

@oSumAtrIX oSumAtrIX linked a pull request Nov 11, 2024 that will close this issue
chore: Merge branch dev to main #65
Draft
@ricnava00
Copy link
Contributor Author

Yes, the issue is fixed. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug report Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Merge branch dev to main ReVanced/revanced-library
2 participants
@oSumAtrIX @ricnava00