-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Cryptosuites #315
Comments
Ask is to refactor cryptosuites to all follow the form outlined by the Data Integrity specification. We should define a method on the interface to run the CVH and other algorithms in a generic manner, without needing to understand the specifics/internals of any cryptosuite See: https://github.com/workdaycredentials/ledger-common/blob/master/proof/ld_signaturesuite.go#L36 |
Much has changed; so we'll need to update the |
The interface, as it stands, is promoting strong coupling across
CryptoSuiteProofType
and a signature algorithm (which is unclear in which interface it's defined). That makes it difficult to know what the expectations are when you're dealing with an implementation. Additionally, it's leaking implementation details because users will need to understand what implementation of the interface is being used.I think the root cause of this is that
CreateVerifyHash()
is part of theCryptoSuiteProofType
interface. Instead, what if there is a separate function with a parameter oftype
CryptoSuiteProofType
? If you need to specify whether the signing algo does digest within it, another method likeIsSignDigested() bool
toCryptoSuiteProofType
. WDYT?Originally posted by @andresuribe87 in #288 (comment)
The text was updated successfully, but these errors were encountered: