Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Private channels do not respond to renames properly #68

Closed
jcolson opened this issue Feb 28, 2019 · 3 comments
Closed

Private channels do not respond to renames properly #68

jcolson opened this issue Feb 28, 2019 · 3 comments

Comments

@jcolson
Copy link
Contributor

jcolson commented Feb 28, 2019

Description
when a channel is renamed, it does not get renamed in irslackd

Steps to reproduce

  1. ... create channel in slack
  2. ... rename channel in slack
  3. ... note that channel is not renamed in irslackd

Expected behavior
channel should be renamed
@jcolson
Copy link
Contributor Author

jcolson commented Feb 28, 2019

hmmm ... i lie ... it looks like maybe it just takes a little bit? closing for now

@jcolson jcolson closed this as completed Feb 28, 2019
@jcolson
Copy link
Contributor Author

jcolson commented Feb 28, 2019

it looks like this happens for private channels

@jcolson jcolson reopened this Feb 28, 2019
jcolson added a commit to jcolson/irslackd that referenced this issue Feb 28, 2019
@jcolson
WIP rename issue adsr#68
08744b5
jcolson added a commit to jcolson/irslackd that referenced this issue Mar 3, 2019
@jcolson
Merge branch 'bug-slack-channel_archive' into bleading
4a583c7 
* bug-slack-channel_archive:
  make sure exception data is json and not undefined for the leaving of slack channel
  fixed being able to /part private channels ... especially when you're the last one in them (needed a call to conversations.archive in the case that last_member error is thrown)
  added subtype group_name and groups.mark call
  WIP rename issue adsr#68
  working on channel_archive and channel_deleted
@jcolson jcolson mentioned this issue Mar 3, 2019
Open
@adsr adsr changed the title when a channel is renamed, it does not get renamed in irslackd Private channels do not respond to renames properly Apr 26, 2019
@adsr adsr mentioned this issue Apr 26, 2019
Open
@adsr
Copy link
Owner

adsr commented Apr 26, 2019

Tracking here #75

@adsr adsr closed this as completed Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adsr @jcolson