Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configured table to use non existent compaction service and saw no errors or warnings #4999

Open
keith-turner opened this issue Oct 18, 2024 · 1 comment
Assignees
Labels
bug This issue has been verified to be a bug.
Milestone

Comments

@keith-turner
Copy link
Contributor

Describe the bug

Configured a table to use non existent compaction service and saw no errors or warnings in the logs. Also no compactions ran for the table even though they needed to.

Expected behavior

The CompactionJobGenerator should log errors or warning for this.

@keith-turner keith-turner added the bug This issue has been verified to be a bug. label Oct 18, 2024
@keith-turner keith-turner added this to the 4.0.0 milestone Oct 18, 2024
@dlmarion
Copy link
Contributor

TabletGroupWatcher.manageTablets calls CheckCompactionConfig.validate at:

CompactionJobGenerator compactionGenerator =
new CompactionJobGenerator(new ServiceEnvironmentImpl(manager.getContext()),
tableMgmtParams.getCompactionHints(), tableMgmtParams.getSteadyTime());
try {
CheckCompactionConfig.validate(manager.getConfiguration());
this.metrics.clearCompactionServiceConfigurationError();
} catch (RuntimeException | ReflectiveOperationException e) {
this.metrics.setCompactionServiceConfigurationError();
LOG.error(
"Error validating compaction configuration, all {} compactions are paused until the configuration is fixed.",
store.getLevel(), e);
compactionGenerator = null;
}

Maybe this is not a case handled by the validate code?

@ddanielr ddanielr self-assigned this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue has been verified to be a bug.
Projects
None yet
Development

No branches or pull requests

3 participants