Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapped response does not expose http.Hijacker interface #1

Open
hlubek opened this issue Aug 10, 2020 · 1 comment
Open

Wrapped response does not expose http.Hijacker interface #1

hlubek opened this issue Aug 10, 2020 · 1 comment

Comments

@hlubek
Copy link

hlubek commented Aug 10, 2020

Some of the special interfaces like http.Hijacker are not exposed using the wrapped response writer.

It would be great to implement something like https://github.com/gorilla/handlers/blob/941e2d87ae774cb93574f1af30684ed9bfe24271/logging.go to implement interfaces for the wrapper if the original response implemented them.

The current implementation prevents Websocket upgrades, so we need to create our own version of it.

@tj
Copy link
Member

tj commented Aug 17, 2020

ahh cool I'll try to look into adding that soon! I haven't used websockets in ages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants