Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support uv tool install on Windows #83

Closed
henryiii opened this issue Sep 17, 2024 · 6 comments · Fixed by #87
Closed

Support uv tool install on Windows #83

henryiii opened this issue Sep 17, 2024 · 6 comments · Fixed by #87
Labels
help wanted Extra attention is needed

Comments

@henryiii
Copy link

henryiii commented Sep 17, 2024

On windows, uv tool install gives the warning:

warning: `C:\Users\runneradmin\.local\bin` is not on your PATH. To use installed tools, run `$env:PATH = "C:`\Users`\runneradmin`\.local`\bin;$env:PATH"`.

And then you can't use what it installs.

I think setup-uv should add ~/.local/bin to the path if it's not there and/or on Windows. For a composite action, it would be something like this:

- if: runner.os == "Windows"
  shell: bash
  run: echo "$USERPROFILE/.local/bin" >> $GITHUB_PATH

That's the workaround I'm using in scientific-python/cookie#493.

@charliermarsh
Copy link
Member

Agreed, good call.

@henryiii
Copy link
Author

I think https://github.com/moonrepo/setup-rust does this.

@charliermarsh
Copy link
Member

Thank you.

@charliermarsh charliermarsh added the help wanted Extra attention is needed label Sep 18, 2024
@eifinger
Copy link
Collaborator

I am testing a solution in #87 where the UV_TOOL_BIN_DIR env var is used to place tools on the much faster D: drive. This is then automatically added to the PATH

@ofek
Copy link

ofek commented Sep 18, 2024

Is that drive documented by GitHub? I'm unable to find information about it.

@eifinger
Copy link
Collaborator

Is that drive documented by GitHub? I'm unable to find information about it.

I got it from here: actions/runner-images#8755

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants