Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please consider making wasm dependencies target-specific for wasm targets #62

Open
joshtriplett opened this issue Aug 26, 2020 · 1 comment
Open

Please consider making wasm dependencies target-specific for wasm targets #62

joshtriplett opened this issue Aug 26, 2020 · 1 comment

Comments

@joshtriplett
Copy link

joshtriplett commented Aug 26, 2020 •
edited
Loading

Rather than having a feature to enable to work on wasm, and then erroring out on wasm targets if that feature isn't enabled, please consider making those dependencies target-specific instead (or in addition), so that it never gets pulled in on non-wasm targets.
@yoshuawuyts
Copy link
Contributor

Related: async-rs/async-std#865

@thomaseizinger thomaseizinger mentioned this issue Jul 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joshtriplett @yoshuawuyts