Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if files from the same file collection have different shapes #39

Open
tsalo opened this issue Dec 6, 2023 · 1 comment
Open

Warn if files from the same file collection have different shapes #39

tsalo opened this issue Dec 6, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@tsalo
Copy link
Member

tsalo commented Dec 6, 2023

I initially asked about this in bids-standard/bids-specification#869. For some file collections (e.g., multi-echo or complex-values fMRI data), the files all come from the same acquisition and MUST have the same shape. For others (e.g., qMRI scans), there's no such restriction. As such, I think it would be very useful to raise a warning if the file collection contains files with different sizes.

@effigies
Copy link
Contributor

effigies commented Dec 6, 2023

Should have a think about how to do this in the schema. I think it would require a new association that all files in the collection share. Then we could say something like nifti_header.shape == associated.collection[0].shape.

@effigies effigies added the enhancement New feature or request label Aug 29, 2024
@effigies effigies transferred this issue from bids-standard/legacy-validator Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants