Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acorn at version 7.0.0 #19

Open
ile opened this issue Jul 17, 2023 · 4 comments
Open

Acorn at version 7.0.0 #19

ile opened this issue Jul 17, 2023 · 4 comments

Comments

@ile
Copy link

ile commented Jul 17, 2023

When I installed the latest acorn-node (2.0.1), I get acorn 7.4.1 with it:

{
  "name": "acorn-node",
  "description": "the acorn javascript parser, preloaded with plugins for syntax parity with recent node versions",
  "version": "2.0.1",
  "author": "Renée Kooi <[email protected]>",
  "bugs": {
    "url": "https://github.com/browserify/acorn-node/issues"
  },
  "dependencies": {
    "acorn": "^7.0.0",
    "acorn-walk": "^7.0.0",
    "xtend": "^4.0.2"
  },

Any change of updating the dependencies? Acorn 8 supports JS syntax that would be useful.

@ljharb
Copy link
Member

ljharb commented Jul 17, 2023

Does acorn 8 have the same engines support as acorn 7? If not, updating to it would be a breaking change.

@ile
Copy link
Author

ile commented Jul 19, 2023

Wouldn't it be time to update Browserify?

@ljharb
Copy link
Member

ljharb commented Jul 19, 2023

Breaking changes are always the most costly changes for the ecosystem and are always best avoided. What are the breaking changes in acorn 8?

@ile
Copy link
Author

ile commented Jul 19, 2023

I was looking for the optional chaining syntax, but I see it's supported in acorn 7.3.0 already. But it needs ecmaVersion set (acornjs/acorn#1010) and it seems that it's not set high enough.

Not sure if it can be set at the browserify level, but I suppose it can't.

I don't know about breaking changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants