Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong in Task :react-native-community_slider:compileReleaseJavaWithJavac FAILED #566

Open
orlandoneto23 opened this issue Dec 27, 2023 · 1 comment
Assignees
Labels
bug report Something isn't working platform: Android Issue related to Android platform

Comments

@orlandoneto23
Copy link

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch @react-native-community/[email protected] for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/@react-native-community/slider/android/src/main/java/com/reactnativecommunity/slider/ReactSliderEvent.java b/node_modules/@react-native-community/slider/android/src/main/java/com/reactnativecommunity/slider/ReactSliderEvent.java
index 7c05916..23f0c49 100644
--- a/node_modules/@react-native-community/slider/android/src/main/java/com/reactnativecommunity/slider/ReactSliderEvent.java
+++ b/node_modules/@react-native-community/slider/android/src/main/java/com/reactnativecommunity/slider/ReactSliderEvent.java
@@ -11,6 +11,7 @@ import androidx.annotation.Nullable;
 import com.facebook.react.bridge.Arguments;
 import com.facebook.react.bridge.WritableMap;
 import com.facebook.react.uimanager.events.Event;
+import com.facebook.react.uimanager.events.RCTEventEmitter;
 
 /**
  * Event emitted by a ReactSliderManager when user changes slider position.
@@ -42,13 +43,18 @@ public class ReactSliderEvent extends Event<ReactSliderEvent> {
     return EVENT_NAME;
   }
 
+  @Override
+  public void dispatch(RCTEventEmitter rctEventEmitter) {
+
+  }
+
   @Override
   public short getCoalescingKey() {
     return 0;
   }
 
   @Nullable
-  @Override
+  //@Override
   protected WritableMap getEventData() {
     return serializeEventData();
   }
diff --git a/node_modules/@react-native-community/slider/android/src/main/java/com/reactnativecommunity/slider/ReactSlidingCompleteEvent.java b/node_modules/@react-native-community/slider/android/src/main/java/com/reactnativecommunity/slider/ReactSlidingCompleteEvent.java
index ffdd8de..766249e 100644
--- a/node_modules/@react-native-community/slider/android/src/main/java/com/reactnativecommunity/slider/ReactSlidingCompleteEvent.java
+++ b/node_modules/@react-native-community/slider/android/src/main/java/com/reactnativecommunity/slider/ReactSlidingCompleteEvent.java
@@ -11,6 +11,7 @@ import androidx.annotation.Nullable;
 import com.facebook.react.bridge.Arguments;
 import com.facebook.react.bridge.WritableMap;
 import com.facebook.react.uimanager.events.Event;
+import com.facebook.react.uimanager.events.RCTEventEmitter;
 
 /**
  * Event emitted when the user finishes dragging the slider.
@@ -35,7 +36,12 @@ public class ReactSlidingCompleteEvent extends Event<ReactSlidingCompleteEvent>
         return EVENT_NAME;
     }
 
-    @Override
+  @Override
+  public void dispatch(RCTEventEmitter rctEventEmitter) {
+
+  }
+
+  @Override
     public short getCoalescingKey() {
         return 0;
     }
@@ -46,7 +52,7 @@ public class ReactSlidingCompleteEvent extends Event<ReactSlidingCompleteEvent>
     }
 
     @Nullable
-    @Override
+    //@Override
     protected WritableMap getEventData() {
         return serializeEventData();
     }
diff --git a/node_modules/@react-native-community/slider/android/src/main/java/com/reactnativecommunity/slider/ReactSlidingStartEvent.java b/node_modules/@react-native-community/slider/android/src/main/java/com/reactnativecommunity/slider/ReactSlidingStartEvent.java
index 3a7ace7..8aa596e 100644
--- a/node_modules/@react-native-community/slider/android/src/main/java/com/reactnativecommunity/slider/ReactSlidingStartEvent.java
+++ b/node_modules/@react-native-community/slider/android/src/main/java/com/reactnativecommunity/slider/ReactSlidingStartEvent.java
@@ -11,6 +11,7 @@ import androidx.annotation.Nullable;
 import com.facebook.react.bridge.Arguments;
 import com.facebook.react.bridge.WritableMap;
 import com.facebook.react.uimanager.events.Event;
+import com.facebook.react.uimanager.events.RCTEventEmitter;
 
 /**
  * Event emitted when the user starts dragging the slider.
@@ -35,7 +36,12 @@ public class ReactSlidingStartEvent extends Event<ReactSlidingStartEvent> {
         return EVENT_NAME;
     }
 
-    @Override
+  @Override
+  public void dispatch(RCTEventEmitter rctEventEmitter) {
+
+  }
+
+  @Override
     public short getCoalescingKey() {
         return 0;
     }
@@ -46,7 +52,7 @@ public class ReactSlidingStartEvent extends Event<ReactSlidingStartEvent> {
     }
 
     @Nullable
-    @Override
+    //@Override
     protected WritableMap getEventData() {
         return serializeEventData();
     }

This issue body was partially generated by patch-package.

@BartoszKlonowski BartoszKlonowski added bug report Something isn't working platform: Android Issue related to Android platform labels Jan 11, 2024
@github-project-automation github-project-automation bot moved this to To be analyzed in Slider-Board Aug 29, 2024
@draggie draggie self-assigned this Sep 17, 2024
@draggie draggie moved this from To be analyzed to In Progress in Slider-Board Sep 17, 2024
@draggie
Copy link
Contributor

draggie commented Sep 20, 2024

Hello @orlandoneto23, could you provide more details about the environment and some reproduction steps for this to happen ? Maybe check with the latest version if this is not resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Something isn't working platform: Android Issue related to Android platform
Projects
Status: In Progress
Development

No branches or pull requests

3 participants