Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Info unit images should fall back more gracefully #4414

Open
Scotchester opened this issue Aug 6, 2018 · 1 comment
Open

Info unit images should fall back more gracefully #4414

Scotchester opened this issue Aug 6, 2018 · 1 comment

Comments

@Scotchester
Copy link
Contributor

If an image is not exactly square, bad things happen.

Current behavior

  • a 300x301 image will not render at the desired 150px width

(there may be other current undesirable behaviors related to 25/75 images, but this is the one we just noticed)

Expected behavior

  • the image would render at 150px width, with a height of 150 or 151 depending on rounding

Steps to replicate behavior

  1. Create an Info Unit Group with 25/75 layout
  2. Add an info unit and upload an image to it with a size of 300x301
  3. Preview the page and behold the gigantic image

Screenshots

Current

image pasted at 2018-8-6 12-56

Expected

image pasted at 2018-8-6 14-32

@Scotchester Scotchester changed the title 25/75 info unit images should fall back more gracefully Info unit images should fall back more gracefully Feb 14, 2019
@Scotchester
Copy link
Contributor Author

Title updated to reflect the fact that this can happen on 50/50s, too. (I assume also 33/33/33s, though I haven't witnessed that.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant