Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using should.deep.equal doesn't handle proimise rejection #250

Open
moar55 opened this issue Jun 21, 2018 · 1 comment
Open

Using should.deep.equal doesn't handle proimise rejection #250

moar55 opened this issue Jun 21, 2018 · 1 comment

Comments

@moar55
Copy link

moar55 commented Jun 21, 2018

chai-as-promised: v7.1.1
node: v8.9.4

When I do something as such: doSomethingAsync().should.eventually.deep.eql(8) an error is asserted normally if 8 is a wrong value. However, if i write doSomethingAsync().should.eventually.deep.equal(8) no erroneous assertion occurs and node displays an unhandled promise rejection warning.

@Legogris
Copy link

Legogris commented Aug 1, 2018

Your situation is unclear based on what you wrote. Got some code to share?
Are you properly returning the promise at the end of your test, e.g.
return doSomethingAsync().should.eventually.deep.equal(8)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants