Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binding-apiserver could not delete pods #569

Open
huiwq1990 opened this issue Sep 12, 2023 · 3 comments · Fixed by #592
Open

binding-apiserver could not delete pods #569

huiwq1990 opened this issue Sep 12, 2023 · 3 comments · Fixed by #592
Labels
kind/bug Something isn't working

Comments

@huiwq1990
Copy link
Contributor

huiwq1990 commented Sep 12, 2023

What happened?

When delete pod in subcluster, binding-apiserver could not delete pods.

binding-apiserver error logs:
image
kubectl --cluster clusterpedia get pod
image

What did you expect to happen?

binding-apiserver could delete pods in cache.

How can we reproduce it (as minimally and precisely as possible)?

Use latest clusterpedia version.

Anything else we need to know?

I fixed it by modify pkg/synchromanager/clustersynchro/resource_synchro.go which pass real object to delete event.

image

Clusterpedia Version

~ kubectl exec -it -n clusterpedia-system clusterpedia-binding-apiserver-d9dbc5b56-lzrb5 -- binding-apiserver --version
Clusterpedia v0.7.0

Host Kubernetes version

~ kubectl version
WARNING: This version information is deprecated and will be replaced with the output from kubectl version --short.  Use --output=yaml|json to get the full version.
Client Version: version.Info{Major:"1", Minor:"27", GitVersion:"v1.27.3", GitCommit:"25b4e43193bcda6c7328a6d147b1fb73a33f1598", GitTreeState:"clean", BuildDate:"2023-06-14T09:47:38Z", GoVersion:"go1.20.5", Compiler:"gc", Platform:"darwin/arm64"}
Kustomize Version: v5.0.1
Server Version: version.Info{Major:"1", Minor:"27", GitVersion:"v1.27.3", GitCommit:"25b4e43193bcda6c7328a6d147b1fb73a33f1598", GitTreeState:"clean", BuildDate:"2023-06-15T00:38:14Z", GoVersion:"go1.20.5", Compiler:"gc", Platform:"linux/arm64"}
@huiwq1990 huiwq1990 added the kind/bug Something isn't working label Sep 12, 2023
@clusterpedia-bot
Copy link

Hi @huiwq1990,
Thanks for opening an issue!
We will look into it as soon as possible.

Details

Instructions for interacting with me using comments are available here.
If you have questions or suggestions related to my behavior, please file an issue against the gh-ci-bot repository.

@Iceber
Copy link
Member

Iceber commented Sep 20, 2023

@wuyingjun-lucky @xyz2277 could you take a look at this, please?

@Iceber
Copy link
Member

Iceber commented Nov 20, 2023

#592 (review)

But #592 also requires the memory storage layer to support PartialObjectMetadata, which of course may require other issues and pr to resolve

Also I think that not getting the resource version when deleting may have an effect on #593 as well.

@Iceber Iceber reopened this Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants