Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login flow redirects to landing page instead of previous page #195

Open
bmispelon opened this issue May 15, 2024 · 1 comment
Open

Login flow redirects to landing page instead of previous page #195

bmispelon opened this issue May 15, 2024 · 1 comment
Labels

Comments

@bmispelon
Copy link
Member

I noticed today that the login process seems to lose track of where the user is coming from:

  • Visit a ticket page while not logged in
  • Click "Login" in the navigation
  • Choose "log in with github"

Once login is successful, I find myself redirected to the root page / and not the ticket page that I was browsing when I clicked the "Login" link.

It's slightly annoying and I think it should be fixable by passing the right redirection URL to the login page (via a GET parameter).

@bmispelon
Copy link
Member Author

As reported in #204, this bug ends up breaking the RSS links on the timeline and query pages.

I took a brief look at the problem a few weeks back, and from what I can tell the issue is that the plugin we use for github auth (https://github.com/trac-hacks/trac-github/) doesn't seem to support passing a redirection parameter to control where the user ends up after a successful login.

@bmispelon bmispelon added bug and removed enhancement labels Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant