-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion: _.oneArg, possibly _.twoArgs and/or _.limitArgs #225
Comments
Can I take this up? |
So @jgonggrijp woud it not be possible to isolate the _.ary function from lodash and use that itself ? |
You can! Though it saves effort if you wait until after modularization, see #220. |
In principle, yes. In practice, borrowing code from Lodash tends to be undesirable because the code is very verbose and over-engineered. I just took a look to check and it confirmed my suspicion: Even if the code size isn't as dramatic, writing the code yourself is certainly much easier, as your own opening post demonstrated. |
@jgonggrijp sounds good. Is there any timeline on that? Also, additionally is there any help required? |
Not really, but just to give you an impression:
Not required but certainly welcome:
before modules
|
@yashshah1 we can collaborate on this :). Let me know if you have any ideas on this |
@jgonggrijp thanks for the quick and detailed response. |
@sktguha over in jashkenas/underscore#2871:
When implementing this, we may want to alias
_.oneArg
to_.unary
and_.limitArgs
to_.ary
in order to not create more distance from Lodash than necessary.The text was updated successfully, but these errors were encountered: