Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RCS1260] False Positive #1439

Open
viceroypenguin opened this issue Apr 12, 2024 · 0 comments
Open

[RCS1260] False Positive #1439

viceroypenguin opened this issue Apr 12, 2024 · 0 comments

Comments

@viceroypenguin
Copy link

Product and Version Used:
Roslynator.Analyzers

Steps to Reproduce:
set .editorconfig values:

roslynator_trailing_comma_style = omit_when_single_line
dotnet_diagnostic.RCS1260.severity = warning

Actual Behavior:
Warning RCS1260 on the , at the end of Property1

var value = new Object
{
    Property1 = "Value"{|RCS1260:,|}
}

Expected Behavior:
No warning

var value = new Object
{
    Property1 = "Value",
}

Possible correction:

I believe the following code relies solely on the initializer.Expressions syntax node, when it should be based on the initializer code.

&& expressions.IsSingleLine(cancellationToken: context.CancellationToken))

Other IsSingleLine() checks in this file need similar review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant