New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Template Param Value in JS missing DateTime #381

Open

ArFe opened this issue May 6, 2024 · 0 comments

ArFe commented May 6, 2024 •

edited

Loading

The Template Param Value function is missing DateTime in its JS Sparkplug Payload function.

It should be as simple as this o fix:

       case 13: // DateTime
            if (isSet(object.longValue)) return object.longValue;

tahu/javascript/core/sparkplug-payload/lib/sparkplugbpayload.ts

Lines 239 to 242 in 5736e40

    
           case 12: // String 
        
               if (isSet(object.stringValue)) return object.stringValue; 
        
           default: 
        
               throw new Error(`Invalid Parameter value: ${JSON.stringify(object)}`);

Well, according to the documentation (https://www.eclipse.org/tahu/spec/sparkplug_spec.pdf page 75), it should support all "Basic Data Types" (same document, page 84), so there's actually more missing.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment