Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup _utils.py functions. ✨🧹✨ #3381

Open
tomchristie opened this issue Oct 29, 2024 · 2 comments
Open

Cleanup _utils.py functions. ✨🧹✨ #3381

tomchristie opened this issue Oct 29, 2024 · 2 comments
Labels
refactor Issues and PRs related to code refactoring

Comments

@tomchristie
Copy link
Member

Possibly a good issue for new contributors?...

The _utils.py module has a smorgasbord of utility functions. Many of these are only used in one place in httpx and it would be easier to comprehend if they were inlined, or refactored closer to where they're being used. ✨🧹✨

Pull requests for this should typically tackle one item at a time for easier review. 🤓

@tomchristie tomchristie added the refactor Issues and PRs related to code refactoring label Oct 29, 2024
@RafaelWO
Copy link
Contributor

I'm happy to take a look at this 🙂

Pull requests for this should typically tackle one item at a time for easier review

I'm not fully sure if I understand this correctly. Do you mean per function or per "topic"?

@tomchristie
Copy link
Member Author

@RafaelWO Wonderful, thanks. 😊

Do you mean per function or per "topic"?

Use your own judgement I guess, we can have a conversation if there's any awkward points.
As a guideline, simpler PRs tend to be more easily acceptable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Issues and PRs related to code refactoring
Projects
None yet
Development

No branches or pull requests

2 participants