Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changelog: add GO-2024-3250 remediation entry #18901

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

changelog: add GO-2024-3250 remediation entry #18901

wants to merge 1 commit into from
+3 −0

Conversation

ivanvc
Copy link
Member

@ivanvc ivanvc commented Nov 15, 2024

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.76%. Comparing base (e1b4ffb) to head (4984528).
Report is 4 commits behind head on main.

❗ Current head 4984528 differs from pull request most recent head 8f806e7

Please upload reports for the commit 8f806e7 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 20 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18901      +/-   ##
==========================================
- Coverage   68.78%   68.76%   -0.03%     
==========================================
  Files         420      420              
  Lines       35558    35558              
==========================================
- Hits        24459    24451       -8     
- Misses       9672     9681       +9     
+ Partials     1427     1426       -1

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1b4ffb...8f806e7. Read the comment docs.

@ivanvc
Copy link
Member Author

ivanvc commented Nov 15, 2024

/retest

jmhbnz
jmhbnz reviewed Nov 15, 2024
View reviewed changes
CHANGELOG/CHANGELOG-3.5.md Outdated Show resolved Hide resolved
jmhbnz
jmhbnz approved these changes Nov 16, 2024
View reviewed changes
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @ivanvc

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivanvc, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmhbnz jmhbnz jmhbnz approved these changes

Assignees
No one assigned
Labels
approved size/XS
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[3.5] Bump golang-jwt/jwt to 4.5.1 to address GO-2024-3250
4 participants
@ivanvc @codecov-commenter @k8s-ci-robot @jmhbnz