Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on index-provider v0.15.0 #1880

Open
5 of 10 tasks
gammazero opened this issue Feb 19, 2024 · 1 comment
Open
5 of 10 tasks

Depend on index-provider v0.15.0 #1880

gammazero opened this issue Feb 19, 2024 · 1 comment
Labels

Comments

@gammazero
Copy link
Collaborator

Checklist

  • This is not a question or a support request. If you have any boost related questions, please ask in the discussion forum.
  • This is not a new feature request. If it is, please file a feature request instead.
  • I have searched on the issue tracker and the discussion forum, and there is no existing related issue or discussion.
  • I am running the Latest release, or the most recent RC(release canadiate) for the upcoming release or the dev branch(master), or have an issue updating to any of these.

Boost component

  • boost daemon - storage providers
  • boost client
  • boost UI
  • boost data-transfer
  • boost index-provider
  • Other

Improvement Suggestion

The latest index-provider v0.15.0 drops support for ipnisync over go-data-transfer/graphsync. It was disabled and replaced with ipnisync over libb2phttp in the previous release, and now data-transfer support should be removed.

@LexLuthr
Copy link
Collaborator

@gammazero I think I already dropped the support for Graphsync when we shipped the ipnisync. Can you please double check the config once

if cfg.Enable {
// Join the indexer topic using the market's pubsub instance. Otherwise, the provider
// engine would create its own instance of pubsub down the line in dagsync, which has
// no validators by default.
t, err := ps.Join(topicName)
if err != nil {
llog.Errorw("Failed to join indexer topic", "err", err)
return nil, xerrors.Errorf("joining indexer topic %s: %w", topicName, err)
}
// Get the miner ID and set as extra gossip data.
// The extra data is required by the lotus-specific index-provider gossip message validators.
ma := address.Address(maddr)
opts = append(opts,
engine.WithTopic(t),
engine.WithExtraGossipData(ma.Bytes()),
)
if cfg.Announce.AnnounceOverHttp {
opts = append(opts, engine.WithDirectAnnounce(cfg.Announce.DirectAnnounceURLs...))
}
// Advertisements can be served over HTTP or HTTP over libp2p.
if cfg.HttpPublisher.Enabled {
announceAddr, err := util.ToHttpMultiaddr(cfg.HttpPublisher.PublicHostname, cfg.HttpPublisher.Port)
if err != nil {
return nil, fmt.Errorf("parsing HTTP Publisher hostname '%s' / port %d: %w",
cfg.HttpPublisher.PublicHostname, cfg.HttpPublisher.Port, err)
}
opts = append(opts,
engine.WithHttpPublisherListenAddr(fmt.Sprintf("0.0.0.0:%d", cfg.HttpPublisher.Port)),
engine.WithHttpPublisherAnnounceAddr(announceAddr.String()),
)
if cfg.HttpPublisher.WithLibp2p {
opts = append(opts, engine.WithPublisherKind(engine.Libp2pHttpPublisher))
llog = llog.With("publisher", "http", "announceAddr", announceAddr)
} else {
opts = append(opts, engine.WithPublisherKind(engine.HttpPublisher))
llog = llog.With("publisher", "http and libp2phttp", "announceAddr", announceAddr, "extraGossipData", ma)
}
} else {
// HTTP publisher not enabled, so use only libp2p
opts = append(opts, engine.WithPublisherKind(engine.Libp2pPublisher))
llog = llog.With("publisher", "libp2phttp", "extraGossipData", ma)
}
} else {
opts = append(opts, engine.WithPublisherKind(engine.NoPublisher))
llog = llog.With("publisher", "none")
}
?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

No branches or pull requests

2 participants