Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task minerprotocols causes panic #1119

Open
placer14 opened this issue Jan 29, 2023 · 0 comments · May be fixed by #1120
Open

Task minerprotocols causes panic #1119

placer14 opened this issue Jan 29, 2023 · 0 comments · May be fixed by #1120
Labels
kind/bug Kind: Bug

Comments

@placer14
Copy link
Contributor

Describe the bug:

During the processing of the minerprotocols survey task, we hit a panic.

daemon panic: runtime error: invalid memory address or nil pointer dereference
daemon [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x211a6df]
daemon
daemon goroutine 95743 [running]:
daemon github.com/filecoin-project/lily/tasks/survey/minerprotocols.getMinerAddrInfo({{{0xc0b3faf6b8, 0x4}}, {{0xc0b3faf6c4, 0x4}}, {{0x0, 0x0}}, {0xc062812620, 0x1, 0x1}, 0xffffffffffffffff, ...})
daemon     /go/src/github.com/filecoin-project/lily/tasks/survey/minerprotocols/minerprotocols.go:205 +0x7f
daemon github.com/filecoin-project/lily/tasks/survey/minerprotocols.fetchMinerProtocolModel({0x560e0a8, 0xc085c0b6e0}, {0x7ed8569c4688, 0xc0004ef680}, {{0xc0ba1805f0?, 0xc08b9a7f01?}}, {{{0xc0b3faf6b8, 0x4}}, {{0xc
0b3faf6c4, 0x4}}, ...}, ...)
daemon     /go/src/github.com/filecoin-project/lily/tasks/survey/minerprotocols/minerprotocols.go:155 +0xf8
daemon github.com/filecoin-project/lily/tasks/survey/minerprotocols.(*Task).Process.func1()
daemon     /go/src/github.com/filecoin-project/lily/tasks/survey/minerprotocols/minerprotocols.go:124 +0x138
daemon github.com/gammazero/workerpool.worker(0xc0b801a5b0?)
daemon     /go/pkg/mod/github.com/gammazero/[email protected]/workerpool.go:243 +0x29
daemon created by github.com/gammazero/workerpool.startWorker
daemon     /go/pkg/mod/github.com/gammazero/[email protected]/workerpool.go:234 +0x65

Looks like a nil is being returned from api.StateMinerInfo(ctx, miner, headTs.Key()) even though no error is being return.

Steps to Reproduce:

Run minerprotocols survey task. Wait until the API finds itself in the condition that causes api.StateMinerInfo(ctx, miner, headTs.Key()) to return nil, nil. 😢

Lily Version: v0.13.0
@placer14 placer14 added the kind/bug Kind: Bug label Jan 29, 2023
@placer14 placer14 linked a pull request Jan 29, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Kind: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(survey): Check for nil PeerID before deref filecoin-project/lily
1 participant
@placer14