Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency 'github.com/alecthomas/jsonschema' is no longer maintained #12559

Open
3 of 9 tasks
HappyHacker123 opened this issue Oct 6, 2024 · 3 comments
Open
3 of 9 tasks
Labels
good first issue Good for newcomers kind/feature Kind: Feature

Comments

@HappyHacker123
Copy link

Checklist

  • This is not brainstorming ideas. If you have an idea you'd like to discuss, please open a new discussion on the lotus forum and select the category as Ideas.
  • I have a specific, actionable, and well motivated feature request to propose.

Lotus component

  • lotus daemon - chain sync
  • lotus fvm/fevm - Lotus FVM and FEVM interactions
  • lotus miner/worker - sealing
  • lotus miner - proving(WindowPoSt/WinningPoSt)
  • lotus JSON-RPC API
  • lotus message management (mpool)
  • Other

What is the motivation behind this feature request? Is your feature request related to a problem? Please describe.

Current dependency github.com/alecthomas/jsonschema is archived and no longer maintained.

Describe the solution you'd like

Maintenance has moved to https://github.com/invopop/jsonschema. Update the import path or use replace the module path.

Describe alternatives you've considered

No response

Additional context

No response

@HappyHacker123 HappyHacker123 added the kind/feature Kind: Feature label Oct 6, 2024
@github-project-automation github-project-automation bot moved this to 📌 Triage in FilOz Oct 6, 2024
@rvagg rvagg added the good first issue Good for newcomers label Oct 8, 2024
@rvagg
Copy link
Member

rvagg commented Oct 8, 2024

Thanks @HappyHacker123, we should certainly do this, especially since we already use the new version!

  • api/docgen-openrpc/openrpc.go -> github.com/alecthomas/jsonschema
  • chain/types/fil.go -> github.com/invopop/jsonschema

Both should use the latter.

Should be an easy fix for someone who would like to contribute.

@rjan90 rjan90 moved this from 📌 Triage to 🐱 Todo in FilOz Oct 8, 2024
@rjan90 rjan90 moved this from 🐱 Todo to ⌨️ In Progress in FilOz Oct 8, 2024
@Stebalien
Copy link
Member

This is a bit trickier because we use https://github.com/etclabscore/go-openrpc-reflect which is still on the old version.

There are also a few breaking changes but they don't look that bad (e.g., Type has been renamed to Schema.

So, to fix this someone will need to make a PR to https://github.com/etclabscore/go-openrpc-reflect first.

@kamuik16
Copy link
Contributor

This is a bit trickier because we use https://github.com/etclabscore/go-openrpc-reflect which is still on the old version.

There are also a few breaking changes but they don't look that bad (e.g., Type has been renamed to Schema.

So, to fix this someone will need to make a PR to https://github.com/etclabscore/go-openrpc-reflect first.

Opened this issue etclabscore/go-openrpc-reflect#12, let's see if they upgrade it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers kind/feature Kind: Feature
Projects
Status: ⌨️ In Progress
Development

No branches or pull requests

4 participants