-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow diffing of two OCI artifacts #3839
Comments
/assign |
@sbdtu5498 we don't have automation for assignments in place here. The issue is assigned to @somtochiama so if you'd like to work on it it'd be best to discuss next steps with her. I'd also encourage you to join the next regular meeting. |
Sure, @somtochiama if you aren't working on it, I can pick it up. Thanks for the invitation @makkes! I will make sure to do that. |
@sbdtu5498 You can have a go at it. Something to note is that there is an existing So |
@somtochiama thanks a lot for the information. I will keep that in mind. |
Hey @sbdtu5498 , |
@somtochiama sorry for the delays. I was a bit busy. I need to do testing and add the test cases as well so it is still a WIP. I have left some comments in PR let me know on that as well. |
Hello I just wanted to see if there is any more movement on this? I’d be interested to see this functionality added. cc @sbdtu5498 |
To help people to gather an idea about the difference between two artifacts, we could introduce a
flux diff artifact <URL1> <URL2>
command which provides a (Git like) diff of the differences within the compressedtar+gzip
layers of the Artifact images.To build this functionality, we need to decide on the diff library that should be used. Theoretically, we could piggy back on the diff utility library from go-git in combination with
DiffPrettyText
. However, there are discussions at present to replace this due to certain issues.An additional thing to take into account is that full decompression of
<URL1>
and/or<URL2>
to disk may not be required, but that we rather iterate over the contents usingtar#NewReader
in combination with reading the file contents from the currenttar#Header
usingio.Copy(out, reader)
.The text was updated successfully, but these errors were encountered: