Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[imporvement] - extract all typscript interfaces into common types file #1216

Open
shootermv opened this issue Nov 5, 2024 · 1 comment
Open
Labels
help wanted Extra attention is needed

Comments

@shootermv
Copy link
Contributor

What bug did you find in the codebase?

as far as i can see - there are type definition are located at components files
i think it is better to have all the defiinition at one common file in that way types can be found easily and also - can be reused

@shootermv shootermv added the bug Something isn't working label Nov 5, 2024
@jdwilkin4
Copy link
Contributor

i think it is better to have all the defiinition at one common file in that way types can be found easily and also - can be reused

I think this depends on if that particular type is only used on one file or not.
If that type is only used once, then I don't see a need to move it to the types file and export it.
But if that type is already being resused in multiple files, then yes it does make sense to have it in one file and export it in the files where it is needed

@jdwilkin4 jdwilkin4 added help wanted Extra attention is needed and removed bug Something isn't working labels Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants