Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atom feeds fail to sanitize output HTML #3340

Open
2 tasks done
GiovanH opened this issue Jun 21, 2024 · 0 comments
Open
2 tasks done

Atom feeds fail to sanitize output HTML #3340

GiovanH opened this issue Jun 21, 2024 · 0 comments
Labels

Comments

@GiovanH
Copy link
Contributor

GiovanH commented Jun 21, 2024

  • I have read the Filing Issues and subsequent “How to Get Help” sections of the documentation.

  • I have searched the issues (including closed ones) and believe that this is not a duplicate.

  • Pelican version: 4.9

Issue

Atom feeds require HTML in the summary to be sanitized:

However, the current atom writer does not do this: https://github.com/getpelican/pelican/blob/master/pelican/writers.py#L68-L78

In addition, there is HTML that is valid for a browser, but not valid for atom feeds, like custom-named tags.

The HTML content cannot be used naively as the feed body. Additional sanitization is required here.

Example of issues

https://validator.w3.org/feed/check.cgi?url=https://blog.giovanh.com/feeds/atom.xml

@GiovanH GiovanH added the bug label Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant