Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(replay): Refactor ReplayReader to provide eventsWithSnapshots and touchEvents lists for video replays #80879

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ryan953
Copy link
Member

@ryan953 ryan953 commented Nov 16, 2024

I wanted to move the loop that creates eventsWithSnapshots into ReplayReader, and also the filter that outputs the touchEvents array. The reader does a lot of stuff like this already, and memoizes the results consistently, so I think it should all go together in there.

Also this helps to slim down class VideoReplayerWithInteractions which i want to do, so it can have a simpler & similar interface to class Replayer

@ryan953 ryan953 requested a review from a team as a code owner November 16, 2024 06:31
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 16, 2024
Copy link

codecov bot commented Nov 16, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
static/app/utils/replays/replayReader.tsx 80.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #80879      +/-   ##
==========================================
+ Coverage   74.97%   78.41%   +3.43%     
==========================================
  Files        7207     7206       -1     
  Lines      319509   319465      -44     
  Branches    44001    43986      -15     
==========================================
+ Hits       239559   250515   +10956     
+ Misses      73432    62573   -10859     
+ Partials     6518     6377     -141     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant