ref(replay): Refactor ReplayReader to provide eventsWithSnapshots and touchEvents lists for video replays #80879
+72
−67
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to move the loop that creates
eventsWithSnapshots
into ReplayReader, and also the filter that outputs thetouchEvents
array. The reader does a lot of stuff like this already, and memoizes the results consistently, so I think it should all go together in there.Also this helps to slim down
class VideoReplayerWithInteractions
which i want to do, so it can have a simpler & similar interface toclass Replayer