Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the intended workflow for the Dependabot PRs? #25

Open
nicl opened this issue Jul 31, 2023 · 4 comments
Open

What is the intended workflow for the Dependabot PRs? #25

nicl opened this issue Jul 31, 2023 · 4 comments
Labels
question Further information is requested

Comments

@nicl
Copy link

nicl commented Jul 31, 2023

Hi, just testing this action - thanks for it!

Something that is unclear to me is the intended workflow for Dependabot PRs once the combined PR is opened/merged. Is the idea that the individual Dependabot PRs should be manually closed? I was expecting this action to close individual PRs once they've been added to the combined PR, but this doesn't seem to be the case, and I can't see anything in the code to suggest it should do this either.

If not, should we add this? It seems less helpful to do the work of raising a combined PR if manual action on the individual PRs is still required.

@paulipotter
Copy link

I had the same question. I'm currently looking how can I currently automatically close those combined prs

@gedwards1
Copy link
Contributor

The individual Dependabot PRs automatically always move to a merged state when their commits are merged by the Combined PR for me. Not sure why our individual PRs would behave differently 🤔

@nicl
Copy link
Author

nicl commented Aug 1, 2023

Ah thanks @gedwards1 to clarify sorry. This does indeed work for Dependabot PRs. Do you know the schedule - how quickly this takes effect?

It doesn't work for non-Dependabot tooling though of course (in our case we are hoping to merge across a variety of tools).

@gedwards1
Copy link
Contributor

Oh I misread your initial Comment @nicl, my bad. You're saying that it would be nice if this Action closed the PRs that it added to the Combined PR. I could see the benefit of that.

I didn't create this Action but my understanding of the "intended workflow" is that you just merge the Combined PR and that indirectly causes the open Individual PRs to change to a merged state automatically and immediately. That workflow requires no action by the user to interact with the individual PRs.

If not, should we add this? It seems less helpful to do the work of raising a combined PR if manual action on the individual PRs is still required.

For me this wouldn't be worth the effort to add since how I use it allows me to ignore the original PRs. But if someone added the feature it I'd consider using it.

Do you know the schedule - how quickly this takes effect?

If you're referring to how long it takes for the individual PRs to change to a merged state, then for me it's always been immediately after the Combined PR is merged.

It doesn't work for non-Dependabot tooling though of course (in our case we are hoping to merge across a variety of tools).

I'm surprised to hear that. My understanding/assumption is that this Action should behave identically for non-Dependabot PRs as long as you change the branch-prefix (or branch-regex) parameter that's passed to the action to not be the default dependabot value. But I've never tested that assumption. Maybe I'm missing some context. I exclusively use this Action for Dependabot PRs.

@GrantBirki GrantBirki added the question Further information is requested label Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants