Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_commenters doesn't find commenters when dependabot makes a PR before the script completes. #418

Open
housten opened this issue Jun 5, 2024 · 0 comments · May be fixed by #419
Open

get_commenters doesn't find commenters when dependabot makes a PR before the script completes. #418

housten opened this issue Jun 5, 2024 · 0 comments · May be fixed by #419

Comments

@housten
Copy link

housten commented Jun 5, 2024

In 3 of the last 4 classes I led, script step 2 could not import the commenters because dependabot created issues before step 1 of the script completed and get_commenters is hardcoded to check issue 1.

This one was yesterday:
dependabot: SolidifyDemo/GHDev07#1
add collaborator issue: SolidifyDemo/GHDev07#3

I have created a fix, that I tested on https://github.com/SolidifyDemo/GHDev07, so the _slides folder now contains files for all the commenters on issue 3. I will submit a PR for it.
@housten housten linked a pull request Jun 5, 2024 that will close this issue
Open
@housten housten changed the title get_commenters doesn't find commenters when dependabot makes an issue before the script completes. get_commenters doesn't find commenters when dependabot makes a PR before the script completes. Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dynamically determine issue number housten/training-manual
1 participant
@housten