provide detail about intent-to-process in webhook response #12

travi · 2016-12-30T03:08:11Z

https://developer.github.com/webhooks/testing/#response

do the event type and action checking before acknowledging the webhook

update the status codes to inform whether the webhook will be processed or skipped
provide a more informative message explaining why a webhook was skipped

… when a PR is not from greenkee for #12, #5, and #4

…ok is not for a newly opened PR for #12, #5, and #4

another step toward better responses for #12

travi added a commit that referenced this issue Dec 31, 2016

feat(bad-request): responded to the webhook with a bad-request status…

e6c9762

… when a PR is not from greenkee for #12, #5, and #4

travi added a commit that referenced this issue Dec 31, 2016

test(event-action): backfilled tests for skipping processing if webho…

b94ec85

…ok is not for a newly opened PR for #12, #5, and #4

travi mentioned this issue Feb 8, 2018

github webhook test returns 500 greenkeeper-keeper/reference-instance#122

Closed

travi added a commit that referenced this issue Sep 21, 2018

chore(logs): added logging for reasons that the PR isnt correct

d7cedf3

another step toward better responses for #12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

provide detail about intent-to-process in webhook response #12

provide detail about intent-to-process in webhook response #12

travi commented Dec 30, 2016 •

edited

Loading

provide detail about intent-to-process in webhook response #12

provide detail about intent-to-process in webhook response #12

Comments

travi commented Dec 30, 2016 • edited Loading

travi commented Dec 30, 2016 •

edited

Loading