Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Former monuments being mapped #48

Open
secretlondon opened this issue Oct 16, 2022 · 1 comment
Open

Former monuments being mapped #48

secretlondon opened this issue Oct 16, 2022 · 1 comment

Comments

@secretlondon
Copy link

From trying to unpick this thing I can see that you are using Wikidata items, but without anything being documented.

I've found two UK items which are plotted despite no longer existing.

Shanklin Pier

https://maps.wikilovesmonuments.org/object/105037739 presumably taken from https://www.wikidata.org/wiki/Q105037739. It has heritage designation set, but with an end date (its been demolished)

Vent pipe in Vauxhall
https://maps.wikilovesmonuments.org/object/26480200 using https://www.wikidata.org/wiki/Q26480200

It's still set with heritage designation, but the listed building identifier is set as withdrawn (it's a former 'stink pipe', it's not there I went looking for it).

Are you selecting items based on whether they have heritage designation set? If you tell us what you are using we can fix these errors.

@RichardNevell
Copy link

This is a very good point. In theory images of things that are no longer there are useful, but my concern would be that people use the map to look for something to photograph and end up disappointed. So it would be best to exclude these sites. There seems to be a few aspects to cover:

  • Designations with an end date and no other designation (the distinction is important and sites can be upgraded in their listing or downgraded, but still protected)
  • Sites where the state of conversation is demolished or destroyed (P5816 Q56556915)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants