Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve existing button components #19

Open
anwarulislam opened this issue Jun 20, 2024 · 6 comments
Open

feat: improve existing button components #19

anwarulislam opened this issue Jun 20, 2024 · 6 comments
Assignees
Labels
fosshack Relegated for FOSS Hack Partner Projects Programme

Comments

@anwarulislam
Copy link
Member

We currently have two different components for Button. One is PrimaryButton and the other is SecondaryButton. It's better to combine them into one component and have props for stylings.

@anwarulislam anwarulislam added the fosshack Relegated for FOSS Hack Partner Projects Programme label Jun 20, 2024
@Dev-SK01
Copy link

We currently have two different components for Button. One is PrimaryButton and the other is SecondaryButton. It's better to combine them into one component and have props for stylings.

Can you assign me this to improve button component

@AndrewBastin
Copy link
Member

Hi @Dev-SK01

This issue is reserved for FOSS Hack Partner Projects Programme, can you confirm you have registered for the same ?

Ref: hoppscotch/hoppscotch#4131

@The-x-35
Copy link

Hi @AndrewBastin ,
I have registered for the FOSS Hack event and I also worked on an issue in the web extension of hoppscotch.
Can you assign this issue to me.
Approach to solve the issue, I would delete the secondary button component and rename the primary button as the main button and it already has props in it for styling.
Can you guide me on how can i setup the project?
Also please guide me if I have to do anything else?

@jamesgeorge007
Copy link
Member

Hi, to setup the project locally:

  • Ensure you've Node.js installed and pnpm available as the package manager.
  • Obtain a fork of the repository since you'll have to raise a PR, and clone it locally. Open it in your code editor of choice and install the dependencies with pnpm i.
  • You can find all the available components under ~/src/components.
  • We use Histoire for authoring the component stories. You can spin up the dev server with pnpm dev and access the playground.
  • That's pretty much it. In short, the general component update process involves making changes to the component source, creating a new variant under the story if one already exists to represent the new behaviour, or adding a new story corresponding to the component.

@The-x-35
Copy link

The-x-35 commented Jul 25, 2024

Hi @jamesgeorge007
I was able to setup the project, but I had one issue that when I run the project, I do not see components which are visible on the official site.
here I am attaching screenshots that I only see 1 Stories 16 Variants whereas the production site has 21 Stories 44 Variants
image
image
As you can see, It is not showing components in the dev environment, Please tell me how can I see that so that I start solving the issue.

@The-x-35
Copy link

Ok I solved the issue by pulling the code again and doing a fresh start, if still some components do not appear just refresh the local host

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fosshack Relegated for FOSS Hack Partner Projects Programme
Projects
None yet
Development

No branches or pull requests

5 participants