Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define policy for adding or updating Python dependencies #77

Open
tiran opened this issue Jun 6, 2024 · 6 comments
Open

Define policy for adding or updating Python dependencies #77

tiran opened this issue Jun 6, 2024 · 6 comments
Labels

Comments

@tiran
Copy link

tiran commented Jun 6, 2024

We should create a policy and guiding document how to deal with new dependencies or updates of existing dependencies.

Some thoughts:

  • new dependencies should be avoided unless they bring merit. Any new dependencies adds a permanent overhead.
  • new dependencies must be reviewed for license, compliance, security, and overall community best practices
  • new dependencies and updates must be coordinated with stakeholders for all hardware targets (Nvidia CUDA, AMD ROCm, Intel Gaudi). Gaudi is a bit problematic, because the stack needs downstream builds and forks from Intel.
@leseb
Copy link
Contributor

leseb commented Jun 6, 2024

I like the idea. Additionally, is it worth running an inspection of the current deps as well and see if some could be removed too?

@bjhargrave
Copy link
Contributor

Most of the repos other than instructlab have dependabot keeping dependencies up-to-date. Eventually we need to add dependabot to the instructlab certainly for the workflows but also for the python dependencies.

@russellb
Copy link
Member

russellb commented Jun 7, 2024

Most of the repos other than instructlab have dependabot keeping dependencies up-to-date. Eventually we need to add dependabot to the instructlab certainly for the workflows but also for the python dependencies.

Yes! I've been meaning to look at this, but haven't gotten around to it. It would be great if you were interested in working on this at some point!

@bjhargrave
Copy link
Contributor

It would be great if you were interested in working on this at some point!

It is on my dance card 🕺

@nathan-weinberg
Copy link
Member

We also need to ensure any dependencies that are added are compliant from a licensing POV - @mrutkows is our resident expert on that AFAIK 😄

Copy link

This issue has been automatically marked as stale because it has not had activity within 90 days. It will be automatically closed if no further activity occurs within 30 days.

@github-actions github-actions bot added the stale label Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants