Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update uvicorn's version in lib/requirements.txt to fix installation issue with latest pip #441

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

FuryMartin
Copy link

@FuryMartin FuryMartin commented Aug 15, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

The latest pip has deprecated certain interface, making sedna's dependency uvicorn~=0.14.0 cannot be installed.

This PR change uvicorn's version from 0.14.0 to 0.15.0 to fix this problem.

Which issue(s) this PR fixes:

Fixes #440

@kubeedge-bot kubeedge-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 15, 2024
@kubeedge-bot
Copy link
Collaborator

Welcome @FuryMartin! It looks like this is your first PR to kubeedge/sedna 🎉

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign jaypume after the PR has been reviewed.
You can assign the PR to them by writing /assign @jaypume in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 15, 2024
@FuryMartin FuryMartin changed the title Update requirements.txt Update uvicorn's version in lib/requirements.txt to fix installation issue with latest pip Aug 15, 2024
@JoeyHwong-gk
Copy link
Contributor

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2024
@tangming1996
Copy link
Contributor

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade uvicorn for the Sedna's package
4 participants