Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

agents should get lease namespace and label details from server in connect metadata instead of passing as cli flags #673

Open
ipochi opened this issue Nov 7, 2024 · 0 comments
Open

agents should get lease namespace and label details from server in connect metadata instead of passing as cli flags #673

ipochi opened this issue Nov 7, 2024 · 0 comments

Comments

@ipochi
Copy link
Contributor

ipochi commented Nov 7, 2024 •
edited
Loading

Based on a review comment from @cheftako.

I think it makes sense to avoid any manual errors when passing cli flags to the agent for lease namespace and labels, instead receiving these details from server in connect metadata makes more sense.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ipochi