Support xunit v3 #718
Draft
Support xunit v3 #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial attempt at getting support for xunit v3. Will likely require much more involved changes to be able to support v2 and v3 simulataneously (e.g. a new package). Visual Studio integration does not appear to work.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #718 +/- ##
==========================================
+ Coverage 97.78% 98.52% +0.73%
==========================================
Files 15 15
Lines 271 271
Branches 37 37
==========================================
+ Hits 265 267 +2
+ Misses 3 2 -1
+ Partials 3 2 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Remove redundant reference for xunit.v3.extensibility.core.
`netstandard2.0` is no longer supported, so add `net472` instead.
Remove redundant using statements.
martincostello
added
dependencies
martincostello
commented
Aug 16, 2024
There was a problem hiding this comment.
Delete this when things moved to a new assembly.
Use the right kind of `DiagnosticMessage`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial attempt at getting support for xunit v3.
Will likely require much more involved changes to be able to support v2 and v3 simultaneously (e.g. a new package). Visual Studio integration does not appear to work, and that's making it difficult to debug the fact that the message sink doesn't appear to be working.
Resolves #717.