Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sample App] Support deployment of Consul sample app #39

Open
leecalcote opened this issue Mar 26, 2020 · 5 comments
Open

[Sample App] Support deployment of Consul sample app #39

leecalcote opened this issue Mar 26, 2020 · 5 comments
Labels
area/workloads Applications / services kind/enhancement New feature or request service-mesh/consul Issues related to Consul

Comments

@leecalcote
Copy link
Member

Enhancement Description
Each service mesh generally has one or more associated sample applications that can be used to demonstrate the power of the given service mesh. Consul uses https://github.com/hashicorp/consul-k8s-l7-obs-guide as a sample application.

Desired Behavior
The Consul adapter currently supports deploying sample applications from other service meshes. It should support the canonical Consul sample app, so that users can get the most thorough tour of Consul's features.

@leecalcote leecalcote added the kind/enhancement New feature or request label Mar 26, 2020
@leecalcote leecalcote added the area/workloads Applications / services label Aug 18, 2020
@leecalcote leecalcote added the service-mesh/consul Issues related to Consul label Aug 25, 2020
@0xfirefist
Copy link

Hey @leecalcote,

Can I take this up? This will help me getting started with adapters.

@leecalcote
Copy link
Member Author

@kalradev that's great idea. Even higher priority than this sample app is the addition of Learn Layer5 as a sample app to be supported by the adapter for Consul. The addition of that application means that the Consul adapter will support SMI conformance testing. Let's get you going on that app.

@0xfirefist
Copy link

Great!!
I will start with adding Learn Layer5.

@leecalcote
Copy link
Member Author

Good deal. The Meshery adapter for Open Service Mesh and the Meshery adapter for Istio both support Learn Layer5 (SMI Conformance) and make for good references.

@mgfeller
Copy link
Contributor

The Consul sample app requires quite a bit of additional setup.
I think it would be good if the code could be refactored before that, towards the Kuma-blueprint. I'll add a couple of issues for that, but started with a set of tests (#94).

@kushthedude kushthedude added the hacktoberfest Happy contributing! label Sep 27, 2020
@leecalcote leecalcote removed the hacktoberfest Happy contributing! label Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/workloads Applications / services kind/enhancement New feature or request service-mesh/consul Issues related to Consul
Projects
None yet
Development

No branches or pull requests

4 participants