-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
urequests still using HTTP/1.0 #844
Comments
Hey! I also think it is better to update the header in line 39 of - s.write(b" HTTP/1.0\r\nHost: ")
+ s.write(b" HTTP/2.0\r\nHost: ") As I know, most major web servers and CDNs provide backward compatibility. Therefore there will be no harm by updating it. |
HTTP/2 is a binary protocol and uses HPACK for header compression. Changing this, require additional code to handle the protocol and header compression. I also think the change to HTTP/1.1 may require some additional code, to handle the different connection types : In addition, there are different Transfer-Endocings. |
It would be good to merge back some of the changes from the CircuitPython requests library (they've updated it since originally starting with the MicroPython implementation). In it, they respond with v1.1, though I'm not sure it 100% conforms to spec... https://github.com/adafruit/Adafruit_CircuitPython_Requests/blob/main/adafruit_requests.py |
The urequests module is still using HTTP/1.0 for HTTP requests:
line 39 in micropython-lib/micropython/urllib.urequest/urllib/urequest.py on the master branch:
s.write(b" HTTP/1.0\r\nHost: ")
Since a host header is included, can this be updated to use HTTP/1.1 or even HTTP/2.0?
Some sites (e.g. mongodb) are now responding with '426 Update Required' for HTTP/1.0 requests.
Thanks
The text was updated successfully, but these errors were encountered: