Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[inetstack] Lost packet on close #1431

Open
iyzhang opened this issue Oct 7, 2024 · 0 comments
Open

[inetstack] Lost packet on close #1431

iyzhang opened this issue Oct 7, 2024 · 0 comments
Assignees
Labels
bug Something Isn't Working

Comments

@iyzhang
Copy link
Contributor

iyzhang commented Oct 7, 2024

Description

If there are packets in the send queue or retransmission queue when the application closes the socket, they will be lost because the background coroutine will immediately exit. This might be happening more frequently after we moved all of our packets to go through the send queue.

How to Reproduce

Steps to reproduce the behavior:

  1. Send packets to fill the window
  2. Buffered packets waiting to be sent out.
  3. Close the socket
  4. The last packet is never sent.

Expected Behavior

Any data pushed before the close call should be eventually sent to the destination. If packets are lost, they should be retransmitted. No packets should be lost because TCP must be reliable. The socket should not be totally closed until all data is sent.

@iyzhang iyzhang added the bug Something Isn't Working label Oct 7, 2024
@iyzhang iyzhang self-assigned this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something Isn't Working
Projects
None yet
Development

No branches or pull requests

1 participant