Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add warning for open registration #14963

Merged
merged 6 commits into from
Nov 16, 2024
Merged

add warning for open registration #14963

merged 6 commits into from
Nov 16, 2024

Conversation

syuilo
Copy link
Member

@syuilo syuilo commented Nov 15, 2024

What

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Nov 15, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 19.33%. Comparing base (e26e24b) to head (7c48018).
Report is 12 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/pages/admin/moderation.vue 0.00% 17 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #14963       +/-   ##
============================================
- Coverage    41.62%   19.33%   -22.29%     
============================================
  Files         1564      727      -837     
  Lines       202872   103616    -99256     
  Branches      3708      990     -2718     
============================================
- Hits         84440    20033    -64407     
+ Misses      117825    83030    -34795     
+ Partials       607      553       -54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo marked this pull request as ready for review November 15, 2024 12:06
@syuilo syuilo merged commit cf1b7c7 into develop Nov 16, 2024
24 of 25 checks passed
@syuilo syuilo deleted the open-registration-warning branch November 16, 2024 08:22
@syuilo
Copy link
Member Author

syuilo commented Nov 16, 2024

🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants