No installation instructions #24
Comments
|
Maybe you could use the docker image? Lines 130 to 140 in dc06f82 |
|
Sorry, I'm not sure exactly what it would look like to "use the docker image"... I think this is a really cool project, by the way. What I actually want to do is make a pre-commit hook in my project (using https://pre-commit.com/) to preprocess the yaml with actions-includes. Do you think that would be possible? |
|
If you have docker installed, you should be able to do something like; |
|
I added the following to my docker-compose.yml: But, when I ran I see that the error comes from here: actions-includes/actions_includes/__init__.py Line 998 in dc06f82 But, I'm not sure what exactly is happening. |
|
@mithro, how do you expect for |
|
@icobfred - That looks like an issue with my docker image not containing the git command.... |
|
FYI - @iacobfred, |
|
Can you give it another go now that git should be in the docker image? |
|
@mithro, I pulled the updated image and tried again. Closer this time! But I got another error: In case it helps, here's the workflow file that I tried to process: https://github.com/ModularHistory/modularhistory/blob/main/.github/workflows/integration.yml (It doesn't use |
|
It looks like you hit part of the GitHub expression language syntax I have yet to add support for. |
|
@iacobfred -- Hopefully 5089a36 fixes the issue with your yaml file. |
|
It worked! And I successfully set up a pre-commit git hook (see https://pre-commit.com) to preprocess my workflow files before pushing to main. Here's what I added to my Here's what I added to my |
|
@iacobfred -- Could you send me some documentation updates to tell people how to do this? |
|
@mithro, sure, after I've tested that my setup is working correctly, I'll send documentation updates. |
|
@mithro, I've noticed a small error in the documentation. It says,
But if I reference a local action with |
|
Please send a pull request? |
|
When I tried using This is the step (of the composite action) that couldn't be processed: Here is the action file: https://github.com/ModularHistory/modularhistory/blob/MH-158/.github/actions/setup/action.yml Here is the workflow file: https://github.com/ModularHistory/modularhistory/blob/MH-158/.github/workflows-src/integration.yml |
|
Caused by https://github.com/mithro/actions-includes/blob/main/actions_includes/expressions.py#L898
|
|
@iacobfred Your issue with |
|
Thank you @mithro. I'll create a pull request shortly to add info about using a pre-commit hook. One more issue that I'm running into: if I try to use a |
|
Do you have an example of the string that is failing? |
|
It looks like there might be an interaction with |
|
Perhaps I'm doing something wrong here? |
|
I was able to replicate this, I'm pretty sure the issue is around order of operations in my expression parser. It is pretty hacky :-) |
|
Actually, it just seems to be the fact that I forgot to add the |
|
So, I fixed the missing It turns out there is also an order of operation bug that I need to investigate, but I don't think it will affect you in this case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Can you please add (1) prereqs and (2) installation instructions to the README?
I assumed I could use
poetry add --dev actions-includes. However, when I tried this, I got a SolverProblemError "Because actions-includes (0.0.post117) requires Python >=3.8." (I'm still using Python 3.7, so maybe I can't use actions-includes.)The text was updated successfully, but these errors were encountered: