Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no option to set color axis limits in mne_nirs.visualisation.plot_nirs_source_detector() #540

Open
AlinaSchulte opened this issue Mar 15, 2024 · 1 comment
Labels

Comments

@AlinaSchulte
Copy link

Describe the new feature or enhancement

As far as I am aware, the function mne_nirs.visualisation.plot_nirs_source_detector() has no option of setting the axis limits for the color bar. An argument in the function such as "clim" would be handy to make sure the color axis is representing similiar values when plotting e.g. GLM results of different conditions, to make plots visually comparable.

@drammock
Copy link
Member

agree that it seems like a good idea to expose that functionality. Are you up for making a pull request to add it? In MNE packages we usually call such variables vmin/vmax (scalars) or vlim (tuple of two scalars), with a preference for migrating to vlim everywhere (eventually / gradually). I'm not super familiar with the NIRS codebase though, so if it's exposed everywhere else in the mne_nirs API as vmin / vmax it's fine to follow suit here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants